s-h-a-d-0-w wrote:

			target =  GameObject.Find("Gem_colleted_1_anim");

About this bit of code, it's apparently not good practice to use GameObject.Find in Unity. It's slow and creates a lot of garbage data from what I hear. I still use it when it's easier than a reference, but it's recommended to use a reference when possible. A reference means setting a global variable at the top of your script like

public GameObject target;

and then setting that GameObject prefab(if you have one) within the editor.(Edit: after reading that you now use prefabs, you may have already done this then.) As a side note about this:

Instantiate(target, new Vector3(transform.position.x,transform.position.y, 0f), Quaternion.identity);

you should reference Instantiate as an object itself, meaning it should look like this:

GameObject Gem_collected_1 = Instantiate(target, new Vector3(transform.position.x,transform.position.y, 0f), Quaternion.identity) as GameObject;

then you can reference "Gem_collected_1" afterwards to reference that specific object.

Also, I'm not sure what you plan to use the "ToDestroy" bool, but if you are using it as a timed destroy, you can use this:

Destroy(GameObject, x);

where "GameObject" is the object you're destroying(in this case Gem_collected_1 or whatever you call the object) and "x" is the amount of time you want to wait before destroying the object. So setting 5 for x would wait 5 seconds before destroying.

I actually remade that part of code completely. Now it looks like this.

using UnityEngine;
using System.Collections;

public class gemHandler : MonoBehaviour {
	private Player player;
	//public Transform[] gemsColleted = new Transform[5];
	public Transform gemAnimation;
	GameObject target;
	public int gemType = 0;
	int[] gemAmount = { 1, 2, 5, 10, 25, 100 }; 

	
	// Use this for initialization
	void Start () {
		player = GameObject.FindGameObjectWithTag ("Player").GetComponent<Player> ();
	}
	
	// Update is called once per frame
	void Update () {
	

	}


	void OnTriggerEnter2D(Collider2D col){
		if(col.CompareTag("Player")){

			if(gemType != 5){
			var gemNumber = Instantiate(gemAnimation) as Transform;
			gemNumber.position = transform.position;
			Destroy(gemNumber.gameObject, 1F);
			//gemsCollected+= gemAmount[gemType];
			}

			Destroy(gameObject, .02F);
			//Destroy (col.gameObject);

			player.gemCollected(gemAmount[gemType]);
		}
		
	}
}

As you can see I completely redid my GemHandler.cs, making it a lot shorter and a lot more efficient. First version of it, was made in rush and didn't work correctly.

			target =  GameObject.Find("Gem_colleted_1_anim");

About this bit of code, it's apparently not good practice to use GameObject.Find in Unity. It's slow and creates a lot of garbage data from what I hear. I still use it when it's easier than a reference, but it's recommended to use a reference when possible. A reference means setting a global variable at the top of your script like

public GameObject target;

and then setting that GameObject prefab(if you have one) within the editor.(Edit: after reading that you now use prefabs, you may have already done this then.) As a side note about this:

Instantiate(target, new Vector3(transform.position.x,transform.position.y, 0f), Quaternion.identity);

you should reference Instantiate as an object itself, meaning it should look like this:

GameObject Gem_collected_1 = Instantiate(target, new Vector3(transform.position.x,transform.position.y, 0f), Quaternion.identity) as GameObject;

then you can reference "Gem_collected_1" afterwards to reference that specific object.

Also, I'm not sure what you plan to use the "ToDestroy" bool, but if you are using it as a timed destroy, you can use this:

Destroy(GameObject, x);

where "GameObject" is the object you're destroying(in this case Gem_collected_1 or whatever you call the object) and "x" is the amount of time you want to wait before destroying the object. So setting 5 for x would wait 5 seconds before destroying.

In the future, please just edit your post instead of double, triple, or quadruple posting. Thanks

Sorry about that. Will not do it again, but since I am replying to this. Is it okay if I post a link to a beta version of my game?

https://www.dropbox.com/s/n8d67fhtn3qc6fo/v1.6.zip?dl=0

https://www.youtube.com/watch?v=Od7q_kTla0Q

Apperantly fixing it was easier than I thought. Reworking on the gem system right now. I really dont like the way I did it in first place. It was something like

void OnTriggerEnter2D(Collider2D col){
		//Debug.Log("OnTriggerEnter2D collision name = " + col.gameObject.name);
		/*for (int i = 0; i < gems.Length; i++) {
			if (col.gameObject.name == gems[i]) {*/

		switch (col.gameObject.name) {


		case "Gem_1":

			//Instantiate (gameObject.GetComponent("Gem_collected_1_anim"), new Vector3 (transform.position.x, transform.position.y, 0f), Quaternion.identity);
			//Rigidbody gem_1a = (Rigidbody) Instantiate(Gem_colleted_1_anim, transform.position, transform.rotation);


			target =  GameObject.Find("Gem_colleted_1_anim");
     		Instantiate(target, new Vector3(transform.position.x,transform.position.y, 0f), Quaternion.identity);
			ToDestroy = true;

That for each gem. and I basicly HAD to put each gem number on the map somewhere, so it would create a clone of it. Now I'm using a proper way of doing, using Prefabs.